[manjaro-dev] [linux41] regression with 'x86/cacheinfo: Move cacheinfo sysfs code to generic infrastructure' on AMD i686
Borislav Petkov
bp at alien8.de
Sun Jul 26 16:42:44 CEST 2015
On Sun, Jul 26, 2015 at 12:54:55PM +0200, Philip Müller wrote:
> I can confirm your patch working. However, it might be good to use yours
> and Thomas' in combination to solve this properly.
Please do not top-post.
We could use Thomas' too although from looking at it,
detect_cache_attributes() allocates a per-CPU per_cpu_cacheinfo thing
for each CPU. By the time we hit cache_shared_cpu_map_remove() in
free_cache_attributes(), those per_cpu_cacheinfo(cpu) things are still
allocated. We kfree them in the next step only.
But I like the moving of the check from the CPU hotplug callback to
free_cache_attributes().
So I'll merge the two patches and write up a proper commit message,
unless someone objects.
I'll add your Tested-by too.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
More information about the manjaro-dev
mailing list